You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/15 04:44:41 UTC
[PR] Fix quoted tree path parsing in table views [iotdb]
Caideyipi opened a new pull request, #18884:
URL: https://github.com/apache/iotdb/pull/18884
## Problem
A table-model view whose tree prefix path contains a space fails when the path is written with quoted identifiers:
```sql
AS root."`tv143_cmp_3`"."`a b`".**
```
The parser produced `root.`tv143_cmp_3`.``a b``.**`, which is rejected as an illegal path.
## Cause
The relational parser already preserves backticks returned by `parseNodeString` for identifiers that require them, but `parsePrefixPath` wrapped every node in another pair of backticks.
## Fix
Preserve an existing backtick-wrapped node name and only add backticks when the parsed node name is not already quoted. Add parser and integration regressions covering the tree-to-table view query.
## Tests
- `mvn spotless:apply -pl iotdb-core/datanode`
- `mvn spotless:apply -pl integration-test -P with-integration-tests`
- `mvn compile -pl iotdb-core/datanode -am -DskipTests`
- `CreateViewPrefixPathTest` (1 test, 0 failures)
- `IoTDBTableIT#testCreateViewFromTreePathWithSpaces` was attempted; the local integration environment could not start the ConfigNode and refused the connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix quoted tree path parsing in table views [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18884:
URL: https://github.com/apache/iotdb/pull/18884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org