You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 06:32:56 UTC
[GitHub] [pulsar] mattisonchao commented on a change in pull request #14259: [Management] Fix print error log when server return redirect (http code 307).
mattisonchao commented on a change in pull request #14259:
URL: https://github.com/apache/pulsar/pull/14259#discussion_r805537592
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -503,10 +503,13 @@ protected void internalCreateMissedPartitions(AsyncResponse asyncResponse) {
return null;
});
}
- }).exceptionally(e -> {
- log.error("[{}] Failed to create partitions for topic {}",
- clientAppId(), topicName);
- resumeAsyncResponseExceptionally(asyncResponse, e);
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we need to log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to create partitions for topic {}",
+ clientAppId(), topicName);
+ }
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
Hi @RobertIndie
``resumeAsyncResponseExceptionally `` method has unwrapped the exception.
[The detail is
](https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L764-L774)
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -503,10 +503,13 @@ protected void internalCreateMissedPartitions(AsyncResponse asyncResponse) {
return null;
});
}
- }).exceptionally(e -> {
- log.error("[{}] Failed to create partitions for topic {}",
- clientAppId(), topicName);
- resumeAsyncResponseExceptionally(asyncResponse, e);
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we need to log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to create partitions for topic {}",
+ clientAppId(), topicName);
+ }
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
Hi @RobertIndie
``resumeAsyncResponseExceptionally `` method has unwrapped the exception.
[](https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L764-L774)
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -503,10 +503,13 @@ protected void internalCreateMissedPartitions(AsyncResponse asyncResponse) {
return null;
});
}
- }).exceptionally(e -> {
- log.error("[{}] Failed to create partitions for topic {}",
- clientAppId(), topicName);
- resumeAsyncResponseExceptionally(asyncResponse, e);
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we need to log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to create partitions for topic {}",
+ clientAppId(), topicName);
+ }
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
Hi @RobertIndie
``resumeAsyncResponseExceptionally `` method has unwrapped the exception.
https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L764-L774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org