You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "songgaoye (via GitHub)" <gi...@apache.org> on 2026/10/23 11:58:07 UTC
[PR] perf: move serialized response IOBuf instead of sharing BlockRefs (brpc)
songgaoye opened a new pull request, #3649:
URL: https://github.com/apache/brpc/pull/3649
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
When a Baidu RPC client receives a `SerializedResponse`, its payload is appended from a temporary `IOBuf` using the copy-style overload. This does not copy payload bytes, but duplicates `IOBuf` BlockRefs and performs corresponding reference-count operations before the temporary buffer is destroyed.
### What is changed and the side effects?
Changed:
Use `IOBuf::movable()` when appending the received payload to `SerializedResponse`. The BlockRefs are transferred directly because the source buffer is not used afterwards.
Side effects:
- Performance effects: Reduces BlockRef traversal and reference-count increment/decrement operations on the serialized-response receive path. Benefits are expected mainly for high-QPS or fragmented/large responses.
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] perf: move serialized response IOBuf instead of sharing BlockRefs (brpc)
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3649:
URL: https://github.com/apache/brpc/pull/3649#discussion_r4361966831
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -1047,7 +1047,7 @@ void ProcessRpcResponse(InputMessageBase* msg_base) {
&cntl->response_attachment() : nullptr;
if (cntl->response()->GetDescriptor() == SerializedResponse::descriptor()) {
((SerializedResponse*)cntl->response())->
- serialized_data().append(*res_buf_ptr);
+ serialized_data().append(res_buf_ptr->movable());
Review Comment:
`movable()` makes this append *consume* `*res_buf_ptr` (leaving it empty/invalid-for-assumptions). To prevent future regressions (e.g., someone later reading `res_buf_ptr->size()` or reusing the buffer after this branch), add an explicit comment that `res_buf_ptr` is intentionally consumed here, or refactor to make consumption obvious (e.g., move into a local named variable before appending). This keeps the performance win while making the ownership transfer unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] perf: move serialized response IOBuf instead of sharing BlockRefs (brpc)
Posted by "songgaoye (via GitHub)" <gi...@apache.org>.
songgaoye commented on code in PR #3649:
URL: https://github.com/apache/brpc/pull/3649#discussion_r4362193235
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -1047,7 +1047,7 @@ void ProcessRpcResponse(InputMessageBase* msg_base) {
&cntl->response_attachment() : nullptr;
if (cntl->response()->GetDescriptor() == SerializedResponse::descriptor()) {
((SerializedResponse*)cntl->response())->
- serialized_data().append(*res_buf_ptr);
+ serialized_data().append(res_buf_ptr->movable());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] perf: move serialized response IOBuf instead of sharing BlockRefs (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #3649:
URL: https://github.com/apache/brpc/pull/3649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org