You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/06/18 23:08:07 UTC
Review Request 35624: Occasional concurrent modification exception
during BP provision of large clusters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35624/
-----------------------------------------------------------
Review request for Ambari and Robert Nettleton.
Bugs: AMBARI-12009
https://issues.apache.org/jira/browse/AMBARI-12009
Repository: ambari
Description
-------
When provisioning large clusters via a blueprint, a concurrent modification exception may occur occasionally because the topology manager task executor thread is attempting to create a copy of a collection that is being modified in another thread. Although this exception is caught in the BP provisioning code and retried successfully it is an easy fix and should be fixed in 2.1 to avoid retries which slows down cluster provisioning.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java a48f331
ambari-server/src/test/java/org/apache/ambari/server/topology/HostGroupInfoTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35624/diff/
Testing
-------
Funtional Tests:
- provisioned a large cluster via a blueprint
Unit Tests:
- new test added for existing class which didn't have a test
- currently running entire unit test suite now and will update with results
Thanks,
John Speidel
Re: Review Request 35624: Occasional concurrent modification exception
during BP provision of large clusters
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35624/#review88450
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On June 18, 2015, 6:40 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35624/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 6:40 p.m.)
>
>
> Review request for Ambari and Robert Nettleton.
>
>
> Bugs: AMBARI-12009
> https://issues.apache.org/jira/browse/AMBARI-12009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When provisioning large clusters via a blueprint, a concurrent modification exception may occur occasionally because the topology manager task executor thread is attempting to create a copy of a collection that is being modified in another thread. Although this exception is caught in the BP provisioning code and retried successfully it is an easy fix and should be fixed in 2.1 to avoid retries which slows down cluster provisioning.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java a48f331
> ambari-server/src/test/java/org/apache/ambari/server/topology/HostGroupInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35624/diff/
>
>
> Testing
> -------
>
> Funtional Tests:
> - provisioned a large cluster via a blueprint
>
> Unit Tests:
> - new test added for existing class which didn't have a test
> - currently running entire unit test suite now and will update with results
>
> Results :
> Tests run: 3095, Failures: 0, Errors: 0, Skipped: 28
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 35624: Occasional concurrent modification exception
during BP provision of large clusters
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35624/
-----------------------------------------------------------
(Updated June 18, 2015, 10:40 p.m.)
Review request for Ambari and Robert Nettleton.
Bugs: AMBARI-12009
https://issues.apache.org/jira/browse/AMBARI-12009
Repository: ambari
Description
-------
When provisioning large clusters via a blueprint, a concurrent modification exception may occur occasionally because the topology manager task executor thread is attempting to create a copy of a collection that is being modified in another thread. Although this exception is caught in the BP provisioning code and retried successfully it is an easy fix and should be fixed in 2.1 to avoid retries which slows down cluster provisioning.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java a48f331
ambari-server/src/test/java/org/apache/ambari/server/topology/HostGroupInfoTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35624/diff/
Testing (updated)
-------
Funtional Tests:
- provisioned a large cluster via a blueprint
Unit Tests:
- new test added for existing class which didn't have a test
- currently running entire unit test suite now and will update with results
Results :
Tests run: 3095, Failures: 0, Errors: 0, Skipped: 28
Thanks,
John Speidel
Re: Review Request 35624: Occasional concurrent modification exception
during BP provision of large clusters
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35624/
-----------------------------------------------------------
(Updated June 18, 2015, 9:12 p.m.)
Review request for Ambari and Robert Nettleton.
Bugs: AMBARI-12009
https://issues.apache.org/jira/browse/AMBARI-12009
Repository: ambari
Description
-------
When provisioning large clusters via a blueprint, a concurrent modification exception may occur occasionally because the topology manager task executor thread is attempting to create a copy of a collection that is being modified in another thread. Although this exception is caught in the BP provisioning code and retried successfully it is an easy fix and should be fixed in 2.1 to avoid retries which slows down cluster provisioning.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java a48f331
ambari-server/src/test/java/org/apache/ambari/server/topology/HostGroupInfoTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35624/diff/
Testing
-------
Funtional Tests:
- provisioned a large cluster via a blueprint
Unit Tests:
- new test added for existing class which didn't have a test
- currently running entire unit test suite now and will update with results
Thanks,
John Speidel