You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2012/07/25 11:44:34 UTC
[jira] [Created] (FELIX-3609) Small optimizations
Guillaume Nodet created FELIX-3609:
--------------------------------------
Summary: Small optimizations
Key: FELIX-3609
URL: https://issues.apache.org/jira/browse/FELIX-3609
Project: Felix
Issue Type: Bug
Components: Framework
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422131#comment-13422131 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
Those optimizations have been written after some profiling sessions on Karaf default distribution.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422129#comment-13422129 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
URL: http://svn.apache.org/viewvc?rev=1365506&view=rev
Log:
[FELIX-3609] Optimization: cache BundleRevision's types
URL: http://svn.apache.org/viewvc?rev=1365507&view=rev
Log:
[FELIX-3609] Optimization: avoid unnecessary toString() computations
URL: http://svn.apache.org/viewvc?rev=1365508&view=rev
Log:
[FELIX-3609] Optimization: faster StringMap implementation
URL: http://svn.apache.org/viewvc?rev=1365509&view=rev
Log:
[FELIX-3609] Optimization: keep hooks sorted so that access is faster as they don't need to be sorted again
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-3609:
-----------------------------------
Issue Type: Improvement (was: Bug)
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-3609.
------------------------------------
Resolution: Fixed
Fix Version/s: framework-4.2.0
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3609) Small optimizations
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422428#comment-13422428 ]
Richard S. Hall edited comment on FELIX-3609 at 7/25/12 5:21 PM:
-----------------------------------------------------------------
I didn't spend time investigating why...took me long enough to figure out "what", since there was also another commit causing me issues that I had to revert.
If you've signed an Apache NDA you can get access to the OSGi R4.3 Core CT and see what's happening.
Just wondering, how many hooks to you have in your system anyway? I wouldn't expect for there to be too many, if any.
was (Author: rickhall):
I didn't spend time investigating why...took me long enough to figure out "what", since there was also another commit causing me issues that I had to revert.
If you've signed an Apache NDA you can get access to the OSGi R4.3 Core CT and see what's happening.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422445#comment-13422445 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
Actually, it seems the only hooks I have are 6 URLStreamHandlerService and they need to be sorted each time a URL object is created.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422489#comment-13422489 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
And yes, I have a NDA filed at the ASF, so I'd be glad if you can give me the needed stuff for passing the CT.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422428#comment-13422428 ]
Richard S. Hall commented on FELIX-3609:
----------------------------------------
I didn't spend time investigating why...took me long enough to figure out "what", since there was also another commit causing me issues that I had to revert.
If you've signed an Apache NDA you can get access to the OSGi R4.3 Core CT and see what's happening.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422477#comment-13422477 ]
Richard S. Hall commented on FELIX-3609:
----------------------------------------
Yeah, I forgot that we unified URL handers with the other hooks...
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422413#comment-13422413 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
Interesting, do you have any more infos ? Are hooks supposed to be sorted ?
I've followed the code path and they seemed to always end up being sorted the same way, so I thought it was a good idea to keep them sorted all time.
The only access to the m_allHooks I found is from getHooks() which does the sort every time before returning. So I kinda fail to see what kind of regression it could cause.
Anyway, sorting all the hooks each time they are accessed (so each time a service listener is added/removed or a search for service references) is quite cpu intensive. I'd still like to get that fix somehow if possible.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-3609.
------------------------------------
Resolution: Fixed
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423123#comment-13423123 ]
Guillaume Nodet commented on FELIX-3609:
----------------------------------------
Added back a fixed version to keep hooks sorted.
URL: http://svn.apache.org/viewvc?rev=1366025&view=rev
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (FELIX-3609) Small optimizations
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall reopened FELIX-3609:
------------------------------------
I rolled back 1365509 since it causes failures in the CT test for weaving hooks.
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3609) Small optimizations
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422507#comment-13422507 ]
Richard S. Hall commented on FELIX-3609:
----------------------------------------
I think you should already have sufficient karma since you have karma for Java EE TCK. Check OSGi CT access here:
https://svn.apache.org/repos/tck/osgi-cts
If you have it, then you may also be interested in:
http://felix.apache.org/site/using-the-osgi-compliance-tests.html
> Small optimizations
> -------------------
>
> Key: FELIX-3609
> URL: https://issues.apache.org/jira/browse/FELIX-3609
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: framework-4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira