You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/29 19:16:06 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #18195: Specify mxnetci dockerhub user in docker-compose.yml

leezu opened a new pull request #18195:
URL: https://github.com/apache/incubator-mxnet/pull/18195


   As `docker-compose push` is now used to push the respective images to the dockerhub, we must specify the username in the `docker-compose.yml`.
   
   Reference http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-docker-cache-refresh/detail/master/2841/pipeline where CI attempts to push the image to the docker.io/library/build.centos7_cpu repository instead of docker.io/mxnetci/build.centos7_cpu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18195: Specify mxnetci dockerhub user in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18195:
URL: https://github.com/apache/incubator-mxnet/pull/18195#discussion_r417587001



##########
File path: ci/docker/docker-compose.yml
##########
@@ -29,7 +29,7 @@ services:
   centos7_cpu:
     # The resulting image will be named build.centos7_cpu:latest and will be
     # pushed to mxnetci under this name
-    image: build.centos7_cpu:latest
+    image: mxnetci/build.centos7_cpu:latest

Review comment:
       https://docs.docker.com/compose/compose-file/#variable-substitution




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18195: Specify mxnetci dockerhub user in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18195:
URL: https://github.com/apache/incubator-mxnet/pull/18195#issuecomment-621409560


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-cpu, edge, unix-gpu, miscellaneous, sanity, centos-cpu, centos-gpu, windows-gpu, website, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #18195: Specify mxnetci dockerhub user in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #18195:
URL: https://github.com/apache/incubator-mxnet/pull/18195#discussion_r417561123



##########
File path: ci/docker/docker-compose.yml
##########
@@ -29,7 +29,7 @@ services:
   centos7_cpu:
     # The resulting image will be named build.centos7_cpu:latest and will be
     # pushed to mxnetci under this name
-    image: build.centos7_cpu:latest
+    image: mxnetci/build.centos7_cpu:latest

Review comment:
       Can we parametrize this? This code is not testable in another environment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18195: Specify mxnetci dockerhub user in docker-compose.yml

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18195:
URL: https://github.com/apache/incubator-mxnet/pull/18195#discussion_r417586601



##########
File path: ci/docker/docker-compose.yml
##########
@@ -29,7 +29,7 @@ services:
   centos7_cpu:
     # The resulting image will be named build.centos7_cpu:latest and will be
     # pushed to mxnetci under this name
-    image: build.centos7_cpu:latest
+    image: mxnetci/build.centos7_cpu:latest

Review comment:
       I don't think that's possible

##########
File path: ci/docker/docker-compose.yml
##########
@@ -29,7 +29,7 @@ services:
   centos7_cpu:
     # The resulting image will be named build.centos7_cpu:latest and will be
     # pushed to mxnetci under this name
-    image: build.centos7_cpu:latest
+    image: mxnetci/build.centos7_cpu:latest

Review comment:
       I don't think that's possible




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org