You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/08/15 10:13:03 UTC

[GitHub] flink pull request #2288: Feature/s3 a fix

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2288#discussion_r74742684
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java ---
    @@ -46,12 +47,13 @@ public void run() {
     
     					FileSystem fs = FileSystem.get(remotePath, hadoopConf);
     
    -					fs.copyFromLocalFile(new Path(localPath.getAbsolutePath()),
    -							new Path(remotePath));
    +					copyFromLocalFile(fs, localPath, checkInitialDirectory(fs,localPath,remotePath));
    --- End diff --
    
    Whitespace between arguments missing, use `fs, localPath, remotePath`, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---