You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2017/01/04 03:48:45 UTC

[GitHub] incubator-gearpump pull request #128: [GEARPUMP-254] fix gearpump on Yarn

GitHub user huafengw opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/128

    [GEARPUMP-254] fix gearpump on Yarn

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huafengw/incubator-gearpump fixYarn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit f40bedf916864c4ac5b573287c6429a7b2ce8892
Author: huafengw <fv...@gmail.com>
Date:   2017-01-04T03:27:16Z

    [GEARPUMP-254] fix gearpump on Yarn

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #128: [GEARPUMP-254] fix gearpump on Yarn

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/128
  
    +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #128: [GEARPUMP-254] fix gearpump on Yarn

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #128: [GEARPUMP-254] fix gearpump on Yarn

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/128
  
    UT failed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #128: [GEARPUMP-254] fix gearpump on Yarn

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/128
  
    ## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/128?src=pr) is 70.79% (diff: 100%)
    > Merging [#128](https://codecov.io/gh/apache/incubator-gearpump/pull/128?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.41%**
    
    
    ```diff
    @@             master       #128   diff @@
    ==========================================
      Files           186        186          
      Lines          5988       5988          
      Methods        5469       5469          
      Messages          0          0          
      Branches        517        517          
    ==========================================
    + Hits           4214       4239    +25   
    + Misses         1774       1749    -25   
      Partials          0          0          
    ```
    
    ![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/128/graphs/sunburst.svg?src=pr&size=150)
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [2783559...4e14131](https://codecov.io/gh/apache/incubator-gearpump/compare/2783559dbf1fe0dd5f090cece152bef65251d5b8...4e14131227396cb77772b980376fdcb66d6a0314?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---