You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/03/18 07:53:17 UTC
[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9712
Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version
......................................................................
IMPALA-6695: Fix PyPi regex, update setuptools version
pytest-runner, which is required by kudu-python requires are more recent
version of setuptools. Adding an explicit dependency required an update
to the regular expression to parse PyPi URLs.
Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
---
M infra/python/deps/pip_download.py
M infra/python/deps/requirements.txt
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/9712/1
--
To view, visit http://gerrit.cloudera.org:8080/9712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
Gerrit-Change-Number: 9712
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9712 )
Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version
......................................................................
Patch Set 1: Code-Review+2
Clean cherry-pick.
--
To view, visit http://gerrit.cloudera.org:8080/9712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
Gerrit-Change-Number: 9712
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Mar 2018 17:42:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9712 )
Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version
......................................................................
Patch Set 1: Verified+1
Successful pre-submit job here: https://jenkins.impala.io/job/gerrit-verify-dryrun/2130/
--
To view, visit http://gerrit.cloudera.org:8080/9712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
Gerrit-Change-Number: 9712
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Mar 2018 16:40:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9712 )
Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version
......................................................................
IMPALA-6695: Fix PyPi regex, update setuptools version
pytest-runner, which is required by kudu-python requires are more recent
version of setuptools. Adding an explicit dependency required an update
to the regular expression to parse PyPi URLs.
Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
Reviewed-on: http://gerrit.cloudera.org:8080/9712
Tested-by: Lars Volker <lv...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
---
M infra/python/deps/pip_download.py
M infra/python/deps/requirements.txt
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia67189f81a31a9a5a0ed80cd4d6661762ef427b2
Gerrit-Change-Number: 9712
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>