You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2007/06/30 19:03:05 UTC
[jira] Created: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
----------------------------------------------------------------------------------
Key: HTTPCORE-88
URL: https://issues.apache.org/jira/browse/HTTPCORE-88
Project: HttpComponents Core
Issue Type: Improvement
Affects Versions: 4.0-alpha5
Reporter: Oleg Kalnichevski
Fix For: 4.0-beta1
Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
(1) an interceptor be put last
(2) an interceptor be put first
(3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509314 ]
Oleg Kalnichevski commented on HTTPCORE-88:
-------------------------------------------
> addRequestInterceptor(HttpRequestInterceptor itcp, int index)
> addResponseInterceptor(HttpResponseInterceptor itcp, int index)
Works for me
Oleg
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Andrea Selva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510863 ]
Andrea Selva commented on HTTPCORE-88:
--------------------------------------
Hi Oleg,
i've signed and sended viafacsimile to the Apache Softwaqre Foundeation:-)
Many thanks
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
> Attachments: improved_add_interceptpr_method.patch
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-88.
---------------------------------------
Resolution: Fixed
Andrea,
I checked the patch in with some changes (more or less minor). Many thanks for this contribution.
Oleg
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
> Attachments: improved_add_interceptpr_method.patch
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Andrea Selva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Selva updated HTTPCORE-88:
---------------------------------
Attachment: improved_add_interceptpr_method.patch
Hi,
here is a patch that should satisfy this issue, the only problem is that i can't update the AbstractHttpClient because the my build system can't see the updates to the BasicHttpProcessor, i hope this could help
Andrea
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
> Attachments: improved_add_interceptpr_method.patch
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509365 ]
Oleg Kalnichevski commented on HTTPCORE-88:
-------------------------------------------
Lovely. I LOVE patches!
Andrea,
I'll review the patch more carefully and check it it right after the ALPHA5 release (we are still in the code freeze pending the release). Meanwhile consider sending in your CLA so we could put your name in the @author tag of files you have worked on.
http://www.apache.org/licenses/
http://www.apache.org/licenses/icla.txt
Oleg
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
> Attachments: improved_add_interceptpr_method.patch
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-88) Add convenience methods to
HttpRequestInterceptorList, HttpResponseInterceptorList
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509312 ]
Roland Weber commented on HTTPCORE-88:
--------------------------------------
addRequestInterceptor(HttpRequestInterceptor itcp, int index)
addResponseInterceptor(HttpResponseInterceptor itcp, int index)
would be my preferred solution, index 0 for first, and negative or MAX_INTEGER for last. I know that I thought about this before, but I don't remember why I didn't put it in when I touched that code. Maybe because we discussed setting up the interceptors once in advance and leaving them unchanged afterwards?
cheers,
Roland
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList
> ----------------------------------------------------------------------------------
>
> Key: HTTPCORE-88
> URL: https://issues.apache.org/jira/browse/HTTPCORE-88
> Project: HttpComponents Core
> Issue Type: Improvement
> Affects Versions: 4.0-alpha5
> Reporter: Oleg Kalnichevski
> Fix For: 4.0-beta1
>
>
> Add convenience methods to HttpRequestInterceptorList, HttpResponseInterceptorList to allow
> (1) an interceptor be put last
> (2) an interceptor be put first
> (3) interceptors removed by a class name
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org