You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-commits@incubator.apache.org by aw...@apache.org on 2006/10/18 00:06:28 UTC
svn commit: r465104 - in
/incubator/adffaces/trunk/trinidad/trinidad-impl/src:
main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/
test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/
Author: awiner
Date: Tue Oct 17 17:06:26 2006
New Revision: 465104
URL: http://svn.apache.org/viewvc?view=rev&rev=465104
Log:
ADFFACES-221: show Error Message Icon on PDAs when an error occurs
Modified:
incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/PdaHtmlSkin.java
incubator/adffaces/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/icon-minimalPPC-golden.xml
Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/PdaHtmlSkin.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/PdaHtmlSkin.java?view=diff&rev=465104&r1=465103&r2=465104
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/PdaHtmlSkin.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/PdaHtmlSkin.java Tue Oct 17 17:06:26 2006
@@ -52,9 +52,7 @@
// and subclasses of PdaHtmlSkin.
private static final Object[] _CUSTOMIZABLE_ICONS = new Object[]
{
- // null out icons that have a default in base skin
- SkinSelectors.ERROR_ICON_ALIAS_NAME,
- NullIcon.sharedInstance(),
+ // null out icons that have an undesirable default in base skin
SkinSelectors.WARNING_ICON_ALIAS_NAME,
NullIcon.sharedInstance(),
SkinSelectors.INFO_ICON_ALIAS_NAME,
Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/icon-minimalPPC-golden.xml
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/icon-minimalPPC-golden.xml?view=diff&rev=465104&r1=465103&r2=465104
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/icon-minimalPPC-golden.xml (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/icon-minimalPPC-golden.xml Tue Oct 17 17:06:26 2006
@@ -1,140 +1,146 @@
-<results>
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- >
- *
- </span>
-<!--AttributeTest[name,info]-->
-
-<!--AttributeTest[name,warning]-->
-
-<!--AttributeTest[name,error]-->
-
-<!--AttributeTest[id,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="test-id"
- >
- *
- </span>
-<!--AttributeTest[inlineStyle,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- style="test-inlineStyle"
- >
- *
- </span>
-<!--AttributeTest[rendered,false]-->
-
-<!--AttributeTest[rendered,true]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- >
- *
- </span>
-<!--AttributeTest[shortDesc,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- title="test-shortDesc"
- >
- *
- </span>
-<!--AttributeTest[onclick,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onclick="test-onclick"
- >
- *
- </span>
-<!--AttributeTest[ondblclick,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- ondblclick="test-ondblclick"
- >
- *
- </span>
-<!--AttributeTest[onkeydown,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onkeydown="test-onkeydown"
- >
- *
- </span>
-<!--AttributeTest[onkeypress,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onkeypress="test-onkeypress"
- >
- *
- </span>
-<!--AttributeTest[onkeyup,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onkeyup="test-onkeyup"
- >
- *
- </span>
-<!--AttributeTest[onmousedown,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onmousedown="test-onmousedown"
- >
- *
- </span>
-<!--AttributeTest[onmousemove,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onmousemove="test-onmousemove"
- >
- *
- </span>
-<!--AttributeTest[onmouseout,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onmouseout="test-onmouseout"
- >
- *
- </span>
-<!--AttributeTest[onmouseover,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onmouseover="test-onmouseover"
- >
- *
- </span>
-<!--AttributeTest[onmouseup,null]-->
-
- <span
- class="AFRequiredIconStyle"
- id="mainId"
- onmouseup="test-onmouseup"
- >
- *
- </span>
-</results>
+<results>
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ >
+ *
+ </span>
+<!--AttributeTest[name,info]-->
+
+<!--AttributeTest[name,warning]-->
+
+<!--AttributeTest[name,error]-->
+
+ <span
+ class="AFErrorIconStyle"
+ id="mainId"
+ >
+ X
+ </span>
+<!--AttributeTest[id,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="test-id"
+ >
+ *
+ </span>
+<!--AttributeTest[inlineStyle,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ style="test-inlineStyle"
+ >
+ *
+ </span>
+<!--AttributeTest[rendered,false]-->
+
+<!--AttributeTest[rendered,true]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ >
+ *
+ </span>
+<!--AttributeTest[shortDesc,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ title="test-shortDesc"
+ >
+ *
+ </span>
+<!--AttributeTest[onclick,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onclick="test-onclick"
+ >
+ *
+ </span>
+<!--AttributeTest[ondblclick,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ ondblclick="test-ondblclick"
+ >
+ *
+ </span>
+<!--AttributeTest[onkeydown,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onkeydown="test-onkeydown"
+ >
+ *
+ </span>
+<!--AttributeTest[onkeypress,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onkeypress="test-onkeypress"
+ >
+ *
+ </span>
+<!--AttributeTest[onkeyup,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onkeyup="test-onkeyup"
+ >
+ *
+ </span>
+<!--AttributeTest[onmousedown,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onmousedown="test-onmousedown"
+ >
+ *
+ </span>
+<!--AttributeTest[onmousemove,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onmousemove="test-onmousemove"
+ >
+ *
+ </span>
+<!--AttributeTest[onmouseout,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onmouseout="test-onmouseout"
+ >
+ *
+ </span>
+<!--AttributeTest[onmouseover,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onmouseover="test-onmouseover"
+ >
+ *
+ </span>
+<!--AttributeTest[onmouseup,null]-->
+
+ <span
+ class="AFRequiredIconStyle"
+ id="mainId"
+ onmouseup="test-onmouseup"
+ >
+ *
+ </span>
+</results>