You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/30 00:13:41 UTC

Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-4489
    https://issues.apache.org/jira/browse/MESOS-4489


Repository: mesos


Description
-------

Implemented the `status` method in `CgroupNetClsIsolatorProcess`.


Diffs
-----

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42947/diff/


Testing
-------


Thanks,

Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review117075
-----------------------------------------------------------



Bad patch!

Reviews applied: [42947]

Failed command: ./support/apply-review.sh -n -r 42947

Error:
2016-01-30 01:26:23 URL:https://reviews.apache.org/r/42947/diff/raw/ [2135/2135] -> "42947.patch" [1]
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp:57
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11129/console

- Mesos ReviewBot


On Jan. 29, 2016, 11:16 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
>     https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review117877
-----------------------------------------------------------



Bad patch!

Reviews applied: [42586, 42587, 42588, 43096, 42618]

Failed command: ./support/apply-review.sh -n -r 42618

Error:
2016-02-04 20:12:20 URL:https://reviews.apache.org/r/42618/diff/raw/ [10980/10980] -> "42618.patch" [1]
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp:35
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp:355
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11249/console

- Mesos ReviewBot


On Feb. 4, 2016, 6:32 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 6:32 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
>     https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review118260
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 401)
<https://reviews.apache.org/r/42947/#comment179479>

    Indentation.



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 412)
<https://reviews.apache.org/r/42947/#comment179480>

    s/CgroupInfo_NetCls/CgroupInfo::NetCls/



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 413)
<https://reviews.apache.org/r/42947/#comment179481>

    why the extra '(' and ')'?



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 416 - 417)
<https://reviews.apache.org/r/42947/#comment179482>

    This is not needed. Please kill it.


- Jie Yu


On Feb. 8, 2016, 6:44 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
>     https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review118210
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42947]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 6:44 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
>     https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>