[GitHub] [spark] otterc commented on a diff in pull request #40921: [SPARK-43242] fix throw 'Unexpected type of BlockId' in diagnose when…

["otterc (via GitHub)" <gi...@apache.org>]

otterc commented on code in PR #40921:
URL: https://github.com/apache/spark/pull/40921#discussion_r1176931684


##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -1139,7 +1139,12 @@ final class ShuffleBlockFetcherIterator(
       case shuffleBlockChunk: ShuffleBlockChunkId =>
         // TODO SPARK-36284 Add shuffle checksum support for push-based shuffle
         val diagnosisResponse = s"BlockChunk $shuffleBlockChunk is corrupted but corruption " +
-          s"diagnosis is skipped due to lack of shuffle checksum support for push-based shuffle."
+          "diagnosis is skipped due to lack of shuffle checksum support for push-based shuffle."
+        logWarning(diagnosisResponse)
+        diagnosisResponse
+      case shuffleBlockBatch: ShuffleBlockBatchId =>

Review Comment:
   Do we have a ticket that tracks building this support for shuffleBlockBatch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org