You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/10 10:47:08 UTC

[GitHub] [incubator-nuttx-apps] jlaitine commented on a diff in pull request #1194: nshlib/nsh_envcmd.c: Change cmd_unset to only unset existing env vari…

jlaitine commented on code in PR #1194:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1194#discussion_r894397551


##########
nshlib/nsh_envcmds.c:
##########
@@ -533,30 +533,46 @@ int cmd_unset(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv)
 {
 #if defined(CONFIG_NSH_VARS) || !defined(CONFIG_DISABLE_ENVIRON)
   int status;
+  FAR char *oldvalue;
 #endif
   int ret = OK;
 
 #if defined(CONFIG_NSH_VARS)
-  /* Unset NSH variable */
+#ifndef CONFIG_DISABLE_ENVIRON
+      /* Check if the NSH variable has already been promoted to an group-

Review Comment:
   mistake, will fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org