You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/09/21 16:48:29 UTC

[PR] Add new linting workflow using Ruff [mahout]

guan404ming opened a new pull request, #568:
URL: https://github.com/apache/mahout/pull/568

   ### Purpose of PR
     Add Ruff linting to the GitHub Actions pipeline to improve Python code quality and enforce consistent formatting across the project's Python components.
   
   ### Linked Issues
   Add links to related issues.
   - Closes #[issue-number] (if applicable)
   
   ### Changes Made
   - [x] New feature
   - [ ] Bug fix
   - [ ] Documentation update
   
   ### Important ToDos
   Please mark each with an "x"
   
   A GitHub issue exists (if not, please create one) [https://github.com/apache/mahout/issues]
   - [ ] Title of PR is "Issue #XXXX: Brief Description of Changes" where XXXX is the GitHub issue number.
   - [x] Created unit tests where appropriate (N/A - this is CI configuration)
   - [x] Added correct licenses on newly added files
   - [ ] Assigned GitHub issue to self
   - [ ] Added documentation in ScalaDocs/JavaDocs and to the website
   - [x] Successfully built and ran all unit tests, verified that all tests pass locally
   
   If all of these items are not yet complete, but you still feel it is appropriate to open a PR, please open it as a **Draft PR** instead.
   Once all requirements are met, you can mark it as ready for review.
   
   ### Breaking Changes
   Does this PR introduce a breaking change?
   - [ ] Yes
   - [x] No
   
   ### Testing & Verification
   Describe how you tested the changes.
   - [x] Manually tested - verified the workflow syntax and configuration
   - [ ] Unit tests added (N/A - this is CI configuration)
   
   **Testing Details:**
   - Verified GitHub Actions workflow syntax is valid
   - Confirmed Poetry dependency management integration
   - Tested Ruff installation and execution in Poetry environment
   
   ### Checklist
   - [x] The title follows the format "MAHOUT-XXXX Brief Description"
   - [ ] GitHub issue is created
   - [x] Code follows ASF guidelines
   
   <img width="1126" height="80" alt="image" src="https://github.com/user-attachments/assets/0018fe75-ec8b-494f-9e8c-9697edbd11ff" />
   
   **Additional Details:**
   - Added new GitHub Actions workflow `.github/workflows/lint.yml`
   - Added Ruff as dev dependency in `pyproject.toml`
   - Runs both linting (`poetry run ruff check`) and formatting checks (`poetry run ruff format --check`)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add new linting workflow using Ruff [mahout]

Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #568:
URL: https://github.com/apache/mahout/pull/568#issuecomment-3319467067

   Can you explain more what Ruff is / why we want to add it? This is another case where an issue first would have been helpful


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add new linting workflow using Ruff [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #568:
URL: https://github.com/apache/mahout/pull/568#issuecomment-3320093297

   > Can you explain more what Ruff is / why we want to add it? This is another case where an issue first would have been helpful
   
   Apologies for not providing enough context earlier. I’ve opened an [issue](https://github.com/apache/mahout/issues/570) regarding this. Could you please take another look when you have a chance? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add new linting workflow using Ruff [mahout]

Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo merged PR #568:
URL: https://github.com/apache/mahout/pull/568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org