You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/18 11:09:02 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue #743: Consolidate datafusion test / make them more uniform
alamb opened a new issue #743:
URL: https://github.com/apache/arrow-datafusion/issues/743
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
As @jorgecarleitao pointed out many moons ago, in https://github.com/apache/arrow/pull/9936#pullrequestreview-632020250 , the tests in datafusion/src/context.rs are not really unit tests. They are more like SQL integration tests.
There is also a small and languishing set of sql tests in `rust/datafusion/tests/sql.rs` that use a string comparison style that I personally find quite hard to upgrade.
Among other things, this split makes it hard to understand the state of DataFusion's test coverage.
Since these tests are critical for DataFusion's quality, I propose a small reorganization so it is easier to find existing test coverage and write new ones:
**Describe the solution you'd like**
Specifically I propose:
- [ ] move the `assert_batches_eq!` macros to a non part of datafusion (among other things so I can share them with IOx)
- [ ] Update the style of all sql.rs tests to be inline with that in context.rs (using assert_batches_eq!)
- [ ] Move tests that are not specific to `ExecutionContext` out of context.rs and into sql.rs
- [ ] (maybe) move `rust/datafusion/src/test` to its own module `rust/test_helpers` (so that it can be shared with sql.rs)
Then over time I imagine being able to organize the tests within sql.rs better (split into multiple modules, for example)
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
None
**Additional context**
Original mailing list thread: https://lists.apache.org/thread.html/r77cb6f55952803debdbe10bb615d00ec097942fb88c1a88496b3d69a%40%3Cdev.arrow.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] matthewmturner commented on issue #743: Consolidate and clean up tests / make them more uniform
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #743:
URL: https://github.com/apache/arrow-datafusion/issues/743#issuecomment-978019233
@alamb i believe we can mark task 2 completed now. If you agree then I can start looking at 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #743: Consolidate and clean up tests / make them more uniform
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #743:
URL: https://github.com/apache/arrow-datafusion/issues/743#issuecomment-978334486
> @alamb i believe we can mark task 2 completed now. If you agree then I can start looking at 3
Done, and THANK YOU!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org