You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/10/16 01:49:46 UTC
Review Request 26788: Added DISTRIBUTE_EGG reference so that protobuf
egg can be built locally.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Added DISTRIBUTE_EGG reference so that protobuf egg can be built locally.
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Oct. 16, 2014, 12:26 a.m., Vinod Kone wrote:
> > Hey Thomas. Can you add more description on what the bug is and what the fix is here? Also, please assign it to a reviewer (me?).
Yup, let me add some more context =)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/#review56847
-----------------------------------------------------------
On Oct. 16, 2014, 12:35 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26788/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 12:35 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added DISTRIBUTE reference so that protobuf egg can be built locally.
>
>
> Diffs
> -----
>
> src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
>
> Diff: https://reviews.apache.org/r/26788/diff/
>
>
> Testing
> -------
>
> make -j6
> make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/#review56847
-----------------------------------------------------------
Hey Thomas. Can you add more description on what the bug is and what the fix is here? Also, please assign it to a reviewer (me?).
- Vinod Kone
On Oct. 15, 2014, 11:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26788/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 11:51 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added DISTRIBUTE reference so that protobuf egg can be built locally.
>
>
> Diffs
> -----
>
> src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
>
> Diff: https://reviews.apache.org/r/26788/diff/
>
>
> Testing
> -------
>
> make -j6
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 12:41 a.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description (updated)
-------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
In MESOS-899, we cleaned the 3rdparty build process up a little bit by no longer making eggs for libraries that we didn't need to. This reference wasn't updated in that patch and needs to be. It has been working for most people because python would go and download the right version for you in the background. The bug ended up being uncovered by users running CI builds without access to external services.
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing
-------
make -j6
make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg
Thanks,
Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 12:35 a.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing (updated)
-------
make -j6
make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg
Thanks,
Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 12:29 a.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
Diffs (updated)
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing
-------
make -j6
Thanks,
Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:51 p.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing (updated)
-------
make -j6
Thanks,
Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf
egg can be built locally.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26788/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:50 p.m.)
Review request for mesos.
Summary (updated)
-----------------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
Repository: mesos-git
Description (updated)
-------
Added DISTRIBUTE reference so that protobuf egg can be built locally.
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
Diff: https://reviews.apache.org/r/26788/diff/
Testing
-------
Thanks,
Thomas Rampelberg