[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1430: HDDS-4227. Implement a 'Prepare For Upgrade' step in OM that applies all committed Ratis transactions.

[GitBox <gi...@apache.org>]

avijayanhwx commented on pull request #1430:
URL: https://github.com/apache/hadoop-ozone/pull/1430#issuecomment-696839280


   > Hi @avijayanhwx
   > 
   > the initial changes look good to me thank you for sharing the wip state, and it seems to be a good direction so far.
   > Maybe one minor comment from me as well, are we sure we want to add --prepareForDowngrade as an option alias? It suggests that we might support downgrade, and I fear that might cause some misunderstandings.
   > I am unsure whether we can use the same functionality to get back to an older version in all scenarios either.
   
   Thanks for the review @fapifta. I agree "downgrades" may not be supportable from each any arbitrary state (post finalize). Since this is a specialized command, I see no harm in adding the alias. When the downgrade is not supported, starting the component in the older version will be flagged out anyway. And, this prepare step is a must do for any supported downgrade. In the future, we may be able to add a bit of validation on the prepareDowngrade step to check finalization state or some marker on disk.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org