You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/09/30 10:24:59 UTC
Review Request 26167: Unable to logout from Admin View,
when ambari-server is stopped
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26167/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-7526
https://issues.apache.org/jira/browse/AMBARI-7526
Repository: ambari
Description
-------
Go to Manage Ambari, stop ambari-server, try to logout. After each click the red square will appear.
**This patch also sets up the unit test and e2e test infrastructure for admin-view.**
Follow below steps to verify working e2e test
1. Apply the patch
2. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
3. npm install
4. npm start (This starts http server at 8000 port)
5. Open another terminal at same path and execute: npm run protractor (does e2e test in chrome browser instance. This library works on top of selenium jar)
Follow below steps to verify unit test:
1. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
2. npm run test-single-run (this uses phantomJS webKit. It's the same used by the ambari-web unit test)
Note:
"npm test" command starts karma server at http://localhost:9876/ and runs unit tests. This server remain up and autoreloads any changes in the test code. This is useful while developing unit tests.
Diffs
-----
ambari-admin/pom.xml 6f70b43
ambari-admin/src/main/resources/ui/admin-web/app/index.html 2fb9fce
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 797ecb2
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js 93377b9
ambari-admin/src/main/resources/ui/admin-web/bower.json 896e5bd
ambari-admin/src/main/resources/ui/admin-web/package.json 0dc99e8
ambari-admin/src/main/resources/ui/admin-web/test/e2e/signout.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/karma.conf.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/protractor-conf.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/spec/test.js a43f4e1
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26167/diff/
Testing
-------
teted e2e
Thanks,
Jaimin Jetly
Re: Review Request 26167: Unable to logout from Admin View,
when ambari-server is stopped
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26167/#review55003
-----------------------------------------------------------
Ship it!
Nice work. I was able to go thru the steps for running E2E tests and unit tests.
- Yusaku Sako
On Sept. 30, 2014, 5:07 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26167/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 5:07 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7526
> https://issues.apache.org/jira/browse/AMBARI-7526
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Go to Manage Ambari, stop ambari-server, try to logout. After each click the red square will appear.
>
> **This patch also sets up the unit test and e2e test infrastructure for admin-view.**
>
> Follow below steps to verify working e2e test
> 1. Apply the patch
> 2. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
> 3. npm install
> 4. npm run update-webdriver
> 5. npm start (This starts http server at 8000 port)
> 6. Open another terminal at same path and execute: npm run protractor (does e2e test in chrome browser instance. This library works on top of selenium jar)
>
> Follow below steps to verify unit test:
> 1. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
> 2. npm run test-single-run (this uses phantomJS webKit. It's the same used by the ambari-web unit test)
>
> Note:
> "npm test" command starts karma server at http://localhost:9876/ and runs unit tests. This server remain up and autoreloads any changes in the test code. This is useful while developing unit tests.
>
>
> Diffs
> -----
>
> ambari-admin/pom.xml 6f70b43
> ambari-admin/src/main/resources/ui/admin-web/app/index.html 2fb9fce
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 797ecb2
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js 93377b9
> ambari-admin/src/main/resources/ui/admin-web/bower.json 896e5bd
> ambari-admin/src/main/resources/ui/admin-web/package.json 0dc99e8
> ambari-admin/src/main/resources/ui/admin-web/test/e2e/signout.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/test/karma.conf.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/test/protractor-conf.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/test/spec/test.js a43f4e1
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26167/diff/
>
>
> Testing
> -------
>
> teted e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26167: Unable to logout from Admin View,
when ambari-server is stopped
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26167/
-----------------------------------------------------------
(Updated Sept. 30, 2014, 5:07 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-7526
https://issues.apache.org/jira/browse/AMBARI-7526
Repository: ambari
Description (updated)
-------
Go to Manage Ambari, stop ambari-server, try to logout. After each click the red square will appear.
**This patch also sets up the unit test and e2e test infrastructure for admin-view.**
Follow below steps to verify working e2e test
1. Apply the patch
2. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
3. npm install
4. npm run update-webdriver
5. npm start (This starts http server at 8000 port)
6. Open another terminal at same path and execute: npm run protractor (does e2e test in chrome browser instance. This library works on top of selenium jar)
Follow below steps to verify unit test:
1. Go to path: /ambari/ambari-admin/src/main/resources/ui/admin-web
2. npm run test-single-run (this uses phantomJS webKit. It's the same used by the ambari-web unit test)
Note:
"npm test" command starts karma server at http://localhost:9876/ and runs unit tests. This server remain up and autoreloads any changes in the test code. This is useful while developing unit tests.
Diffs
-----
ambari-admin/pom.xml 6f70b43
ambari-admin/src/main/resources/ui/admin-web/app/index.html 2fb9fce
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 797ecb2
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js 93377b9
ambari-admin/src/main/resources/ui/admin-web/bower.json 896e5bd
ambari-admin/src/main/resources/ui/admin-web/package.json 0dc99e8
ambari-admin/src/main/resources/ui/admin-web/test/e2e/signout.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/karma.conf.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/protractor-conf.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/spec/test.js a43f4e1
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26167/diff/
Testing
-------
teted e2e
Thanks,
Jaimin Jetly