You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/11/09 00:46:35 UTC
[GitHub] [myfaces] pnicolucci opened a new pull request, #377: MYFACES-4495: Throw NPE when necessary
pnicolucci opened a new pull request, #377:
URL: https://github.com/apache/myfaces/pull/377
https://issues.apache.org/jira/browse/MYFACES-4495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #377: MYFACES-4495: Throw NPE when necessary
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #377:
URL: https://github.com/apache/myfaces/pull/377#issuecomment-1308394228
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on a diff in pull request #377: MYFACES-4495: Throw NPE when necessary
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on code in PR #377:
URL: https://github.com/apache/myfaces/pull/377#discussion_r1017273953
##########
impl/src/main/java/org/apache/myfaces/application/ApplicationImplEventManager.java:
##########
@@ -51,12 +52,17 @@
public void publishEvent(FacesContext facesContext, Class<? extends SystemEvent> systemEventClass, Object source)
{
+ Assert.notNull(source, "source");
Review Comment:
Doing the assert here as well to avoid a non descript NPE when doing a source.getClass()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci merged pull request #377: MYFACES-4495: Throw NPE when necessary
Posted by GitBox <gi...@apache.org>.
pnicolucci merged PR #377:
URL: https://github.com/apache/myfaces/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org