You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/03 09:10:44 UTC
[GitHub] [nifi] lordgamez opened a new pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
lordgamez opened a new pull request #5312:
URL: https://github.com/apache/nifi/pull/5312
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Currently "Include Core Attributes" property filters out any core attributes specified in the "Attributes List" property, but does not filter any attributes matching the regular expression in the "Attributes Regular Expression" property. This makes the functionality of the processor inconsistent. "Include Core Attributes" should not filter out specifically listed attributes in the "Attributes List" property, and this PR removes this filtering.
https://issues.apache.org/jira/browse/NIFI-9058
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [X] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [X] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5312:
URL: https://github.com/apache/nifi/pull/5312#issuecomment-996289997
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5312:
URL: https://github.com/apache/nifi/pull/5312#discussion_r804999842
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToJSON.java
##########
@@ -212,10 +212,7 @@ protected void init(final ProcessorInitializationContext context) {
if (ats != null) {
Set<String> result = new HashSet<>(ats.length);
for (String str : ats) {
- String trim = str.trim();
- if (!atrsToExclude.contains(trim)) {
Review comment:
With this change, the `atrsToExclude` parameter no longer appears to be used, so the method signature should be adjusted and calling code adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] lordgamez commented on a change in pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #5312:
URL: https://github.com/apache/nifi/pull/5312#discussion_r805762668
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToJSON.java
##########
@@ -212,10 +212,7 @@ protected void init(final ProcessorInitializationContext context) {
if (ats != null) {
Set<String> result = new HashSet<>(ats.length);
for (String str : ats) {
- String trim = str.trim();
- if (!atrsToExclude.contains(trim)) {
Review comment:
Thanks for the review! I updated the signature in ff81c1c810bb972ebe7de9d9915fc024a76ec0f2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #5312:
URL: https://github.com/apache/nifi/pull/5312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #5312:
URL: https://github.com/apache/nifi/pull/5312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #5312:
URL: https://github.com/apache/nifi/pull/5312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5312:
URL: https://github.com/apache/nifi/pull/5312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org