[GitHub] [systemds] corepointer commented on a change in pull request #1047: [SYSTEMDS-2651] Add faster multiple federated workers startup

[GitBox <gi...@apache.org>]

corepointer commented on a change in pull request #1047:
URL: https://github.com/apache/systemds/pull/1047#discussion_r519797269



##########
File path: src/test/java/org/apache/sysds/test/AutomatedTestBase.java
##########
@@ -1380,80 +1386,116 @@ public static int getRandomAvailablePort() {
 			return availableSocket.getLocalPort();
 		}
 		catch(IOException e) {
-			// If no port was found just use 9999
+			// If no port was found just use 9990
 			return 9990;
 		}

Review comment:
       Isn't this hiding trouble? Can you explain when this behavior is ever desired to ignore the exception and just return a port? I know, this is actually already being used and the change is just about the comment, but I didn't review the original change, so I speak up now :blush: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org