You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "clmccart (via GitHub)" <gi...@apache.org> on 2024/03/19 17:41:56 UTC
[PR] replace clock.milliseconds with stopwatch [beam]
clmccart opened a new pull request, #30678:
URL: https://github.com/apache/beam/pull/30678
per go/java-practices/time#stopwatch, replace references to clock.milliseconds with the Stopwatch abstraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2039645161
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2021584247
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2034415691
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2039657038
Could you please resolve conflicts? Then I'll merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #30678:
URL: https://github.com/apache/beam/pull/30678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2007928098
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2058945602
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "clmccart (via GitHub)" <gi...@apache.org>.
clmccart commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2007781631
cc: @tudorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace clock.milliseconds with stopwatch [beam]
Posted by "clmccart (via GitHub)" <gi...@apache.org>.
clmccart commented on PR #30678:
URL: https://github.com/apache/beam/pull/30678#issuecomment-2018520226
from tudorm: https://paste.googleplex.com/6292253921771520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org