You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/26 13:11:54 UTC
[GitHub] [incubator-pinot] harishks opened a new pull request #6983: Controller api periodic task trigger
harishks opened a new pull request #6983:
URL: https://github.com/apache/incubator-pinot/pull/6983
## Description
API endpoint to manually trigger controller periodic tasks.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6983: Controller api periodic task trigger
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #6983:
URL: https://github.com/apache/incubator-pinot/pull/6983#issuecomment-855172105
One way to do this is via Helix messages. When a controller receives the request to trigger the task,it sends out a helix message that is receieved by all controllers, and then they trigger the particular task (on a table, if that is also provided).
In any case, please specify the API on the PR so that it is evident that you are adding a new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] harishks commented on pull request #6983: Controller api periodic task trigger
Posted by GitBox <gi...@apache.org>.
harishks commented on pull request #6983:
URL: https://github.com/apache/incubator-pinot/pull/6983#issuecomment-855165557
> What if the task is already running in another controller? Tables are distributed across controllers, and it is assumed in Pinot that when one task runs for a table, it is not running for the same table in another controller.
Thanks for the review. I was basing these changes based on existing periodic tasks, which I believe runs on mutually exclusive set of tables. Should we maintain states that need to be maintained when the task gets run on a given table on a given controller so that the other controller can skip running these tasks on the same table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org