[jira] [Commented] (HBASE-9633) Partial reverse of HBASE-9533

["Nicolas Liochon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774522#comment-13774522 ] 

Nicolas Liochon commented on HBASE-9633:
----------------------------------------

I've created ZOOKEEPER-1763, it will make things easier, but I don't think it's the root cause.
                
> Partial reverse of HBASE-9533
> -----------------------------
>
>                 Key: HBASE-9633
>                 URL: https://issues.apache.org/jira/browse/HBASE-9633
>             Project: HBase
>          Issue Type: Bug
>          Components: build, Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.96.1
>
>         Attachments: 9633.v1.patch
>
>
> I don't understand the solution in HBASE-9533
> In netty 3.3, they changed the group id, if I understand well for legal reasons see https://github.com/netty/netty/issues/103). But they have not changed the java package name: it's still org.jboss.netty. So we should not have to remove our dependency to netty 3.6. 
> So:
> - this comment is wrong imho: the explicit load is not related to the package name but to how mapreduce load work.
> {code}
> +      // This is ugly.  Our zk3.4.5 depends on the org.jboss.netty, not hadoops io.netty
> +      // so need to load it up explicitly while on 3.4.5 zk
> {code}
> - We do use Netty (for the multicast message), so now we're have a missing dependency, as maven says:
> {code}
>  [INFO] — maven-dependency-plugin:2.1:analyze (default-cli) @ hbase-client —
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.jboss.netty:netty:jar:3.2.2.Final:compile
> {code}
> So I propose a partial reverse. [~saint.ack@gmail.com], [@Aleksandr Shulman] would it work for you?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira