You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/18 18:38:42 UTC

[GitHub] [maven] MartinKanters commented on pull request #373: [MNG-6118] submodule invocation

MartinKanters commented on pull request #373:
URL: https://github.com/apache/maven/pull/373#issuecomment-711367021


   > +1 but please consider this approval as non binding. I checked the code and it looks good but I don't know very much this part of Maven. I am not sure we are not breaking something.
   > The fact that integration tests are passing is a good index that this patch is good.
   > 
   > I like this feature. Thanks for providing it
   
   Thanks @eolivelli ! Although non-binding, we are grateful you like the code and the feature. I was confident enough to merge the changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org