[GitHub] [spark] viirya commented on a change in pull request #33865: [SPARK-36607][SQL] Support BooleanType in UnwrapCastInBinaryComparison

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #33865:
URL: https://github.com/apache/spark/pull/33865#discussion_r699677769



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
##########
@@ -1244,48 +1244,6 @@ class TypeCoercionSuite extends AnalysisTest {
     )
   }
 
-  test("BooleanEquality simplification") {
-    val be = TypeCoercion.BooleanEquality
-
-    ruleTest(be,
-      EqualTo(Literal(true), Literal(1)),
-      Literal(true)
-    )

Review comment:
       Do we have same tests for these?
   
   I don't see the same for this one, for example, in `UnwrapCastInBinaryComparisonSuite`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org