[jira] [Resolved] (YUNIKORN-1690) remove redundant if else in sorter

["Craig Condit (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit resolved YUNIKORN-1690.
------------------------------------
     Fix Version/s: 1.3.0
    Target Version: 1.3.0
        Resolution: Fixed

Merged to master. Thanks [~yichiu] for the contribution.

> remove redundant if else in sorter
> ----------------------------------
>
>                 Key: YUNIKORN-1690
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1690
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: yichiu
>            Priority: Trivial
>              Labels: newbie, pull-request-available
>             Fix For: 1.3.0
>
>
> The sorters use an if else construct that is not needed:
> {code:java}
> if leftPriority > rightPriority {
>    return true
> } else if leftPriority < rightPriority {{code}
> The else is not needed as we have a return inside the if. Same construct shows in multiple places.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org