You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/31 14:31:21 UTC
[GitHub] [kafka] Kvicii opened a new pull request, #12232: MINOR:rm deprecated method
Kvicii opened a new pull request, #12232:
URL: https://github.com/apache/kafka/pull/12232
I think createIOThreadRatioMeterLegacy is deprecated, so we need instead of this.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12232: MINOR:rm deprecated method
Posted by GitBox <gi...@apache.org>.
dajac commented on PR #12232:
URL: https://github.com/apache/kafka/pull/12232#issuecomment-1144036865
@Kvicii Thanks for the PR. It seems that those metrics were deprecated in 3.1: https://github.com/apache/kafka/commit/286126f9a53751285e6b71349cdb6abcba35ddff. I think that removing them now is premature. We could consider doing this for 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma closed pull request #12232: MINOR:rm deprecated method
Posted by GitBox <gi...@apache.org>.
ijuma closed pull request #12232: MINOR:rm deprecated method
URL: https://github.com/apache/kafka/pull/12232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #12232: MINOR:rm deprecated method
Posted by GitBox <gi...@apache.org>.
Kvicii commented on PR #12232:
URL: https://github.com/apache/kafka/pull/12232#issuecomment-1143607497
@dajac @hachikuji could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #12232: MINOR:rm deprecated method
Posted by GitBox <gi...@apache.org>.
Kvicii commented on PR #12232:
URL: https://github.com/apache/kafka/pull/12232#issuecomment-1144378242
OK,thx.
Sent from my iPhone
> On Jun 2, 2022, at 03:15, David Jacot ***@***.***> wrote:
>
>
> @Kvicii Thanks for the PR. It seems that those metrics were deprecated in 3.1: 286126f. I think that removing them now is premature. We could consider doing this for 4.0.
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12232: MINOR:rm deprecated method
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12232:
URL: https://github.com/apache/kafka/pull/12232#issuecomment-1156711344
Yes, we only remove deprecated methods during major releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org