You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/17 08:15:41 UTC
[GitHub] [buildstream] gtristan opened a new pull request, #1723: Build and release wheel packages
gtristan opened a new pull request, #1723:
URL: https://github.com/apache/buildstream/pull/1723
This updates the CI config to:
* build x86_64 wheel packages on each update of 'master', which can be downloaded as Action artifacts. The packages contain release binaries of BuildBox casd/fuse/run-bubblewrap.
* build sdist and wheel packages on each release tag, test the wheels, and upload them to Test PyPI at https://test.pypi.org/project/BuildStream/
Before actually landing this, we need to make some changes:
* [x] update documentation around release process and installation (https://gitlab.com/BuildStream/website/-/merge_requests/153)
* [x] release to the real PyPI instead of [Test PyPI](https://test.pypi.org/) (in release.yml)
* [x] create and add a [PyPI API token](https://pypi.org/help/#apitoken) as a [repository secret](https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-encrypted-secrets-for-your-repository-and-organization-for-github-codespaces)
Fixes #1712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1723:
URL: https://github.com/apache/buildstream/pull/1723#issuecomment-1217688304
This branch is a cleanup of #1714 and addresses some of the last review comments (because @ssssam is on vacation for the rest of the week).
This effectively replaces #1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] ssssam commented on pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
ssssam commented on PR #1723:
URL: https://github.com/apache/buildstream/pull/1723#issuecomment-1222493463
The generated wheels cannot build gnome-build-meta due to https://github.com/apache/buildstream/issues/1733. We should resolve that before final release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1723:
URL: https://github.com/apache/buildstream/pull/1723#issuecomment-1223587195
> Here's a patch that fixes buildbox-casd operation with minimal churn: [c529c61](https://github.com/apache/buildstream/commit/c529c615f2dbfb216d03e66c315114e5bc77b3fa)
>
> We could alternatively simplify this branch by removing all the _get_host_tool_internal() helpers and setting `os.environ["PATH"]` on startup to include `os.path.join(_site.subprojects, "buildbox")`.
I've applied the patch to this branch thanks.
I think I also like the patch this way because the `PATH` setting resides in codepaths which are clearly tied to launching buildbox binaries, whereas globally setting `PATH` at startup would have to live in a disconnected/unrelated codepath.
Global environment setting was unavoidable for setting `GRPC_ENABLE_FORK_SUPPORT` in cfe3d71c71 (which is unfortunatly confusing since the generated entrypoint is nowhere close to grpc usage/initialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1723:
URL: https://github.com/apache/buildstream/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1723:
URL: https://github.com/apache/buildstream/pull/1723#issuecomment-1221500951
We recently changed the name of the binaries generated by `buildbox-integration` in https://gitlab.com/BuildGrid/buildbox/buildbox-integration/-/merge_requests/5
So, we are currently waiting for:
* A new tag on `buildbox-integration` repo, so that the new binary name gets published
* Someone please review https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/merge_requests/46 so that this can happen now
* Me to apply the local change I'm holding onto which changes the binary permalink we download binaries from
* A pipeline to pass here with the new change applied
And then we can finally release and tag and see automatically generated and published wheels which include buildbox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] ssssam commented on pull request #1723: Build and release wheel packages
Posted by GitBox <gi...@apache.org>.
ssssam commented on PR #1723:
URL: https://github.com/apache/buildstream/pull/1723#issuecomment-1222537197
Here's a patch that fixes buildbox-casd operation with minimal churn: https://github.com/apache/buildstream/commit/c529c615f2dbfb216d03e66c315114e5bc77b3fa
We could alternatively simplify this branch by removing all the _get_host_tool_internal() helpers and setting `os.environ["PATH"]` on startup to include `os.path.join(_site.subprojects, "buildbox")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org