You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by AlexTsvetkov <gi...@git.apache.org> on 2018/10/23 09:32:54 UTC
[GitHub] syncope pull request #85: Revert: SYNCOPE-1387 fix class cast exception
GitHub user AlexTsvetkov opened a pull request:
https://github.com/apache/syncope/pull/85
Revert: SYNCOPE-1387 fix class cast exception
https://issues.apache.org/jira/projects/SYNCOPE/issues/SYNCOPE-1387
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexTsvetkov/syncope 2_0_X
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 7d9e99af3dfa162d8755ad89d36156493dc739e8
Author: Alexander Tsvetkov <al...@...>
Date: 2018-10-23T09:31:39Z
Revert: SYNCOPE-1387 fix class cast exception
----
---
[GitHub] syncope issue #85: Revert: SYNCOPE-1387 fix class cast exception
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/85
@AlexTsvetkov I have reviewed the code in `DefaultRealmPullResultHandler` and found that you were right about removing the additional `after()` calls - as proposed in #84 .
This because the `link()` method eventually calls `update()` - thus I have tried to clean up a bit the call hierarchy in 5e854e117594da3a1ba78c0af8d53d89a66a9c5a
Please close this PR as well, sorry for the noise; at least, now the issue should be fixed.
For future contributions, please submit an [ICLA](http://syncope.apache.org/contributing#How_do_I_become_a_contributor_or_a_committer.3F), thanks.
---
[GitHub] syncope pull request #85: Revert: SYNCOPE-1387 fix class cast exception
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh closed the pull request at:
https://github.com/apache/syncope/pull/85
---