[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3950: Faster i256 parsing

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3950:
URL: https://github.com/apache/arrow-rs/pull/3950#discussion_r1148531594


##########
arrow-buffer/src/bigint.rs:
##########
@@ -40,6 +59,66 @@ impl std::fmt::Display for i256 {
     }
 }
 
+impl FromStr for i256 {

Review Comment:
   This should make it easier to write decimal parsing logic that is generic over both i128 and i256



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org