You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tan-JiaLiang (via GitHub)" <gi...@apache.org> on 2023/12/04 11:13:36 UTC
[PR] [Bug] Fix the state compatibility problem [doris-flink-connector]
Tan-JiaLiang opened a new pull request, #257:
URL: https://github.com/apache/doris-flink-connector/pull/257
# Proposed changes
Issue Number: close #256
## Problem Summary:
#224 Made a change to DorisWriterState without considering connector state compatibility, resulting in an upgrade to 1.5.0 error, So I wana to fix this.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug] Fix the state compatibility problem [doris-flink-connector]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #257:
URL: https://github.com/apache/doris-flink-connector/pull/257#discussion_r1414811491
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/DorisWriter.java:
##########
@@ -130,6 +130,9 @@ private void abortLingeringTransactions(Collection<DorisWriterState> recoveredSt
if(!state.getLabelPrefix().equals(labelPrefix)){
LOG.warn("Label prefix from previous execution {} has changed to {}.", state.getLabelPrefix(), executionOptions.getLabelPrefix());
}
+ if (state.getDatabase() == null || state.getTable() == null) {
+ continue;
Review Comment:
Thank you for your contribution. Would it be better to add some logs here to inform users that the historical state cannot be aborted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug] Fix the state compatibility problem [doris-flink-connector]
Posted by "Tan-JiaLiang (via GitHub)" <gi...@apache.org>.
Tan-JiaLiang commented on PR #257:
URL: https://github.com/apache/doris-flink-connector/pull/257#issuecomment-1840427192
@JNSimba Thanks for your help with code review, would you mind taking another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug] Fix the state compatibility problem [doris-flink-connector]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #257:
URL: https://github.com/apache/doris-flink-connector/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org