You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 19:58:30 UTC

[GitHub] [spark] c21 commented on a change in pull request #31646: [SPARK-34538][SQL] Hive Metastore support filter by not-in

c21 commented on a change in pull request #31646:
URL: https://github.com/apache/spark/pull/31646#discussion_r583125165



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala
##########
@@ -108,6 +108,28 @@ class FiltersSuite extends SparkFunSuite with Logging with PlanTest {
     (a("datecol", DateType) =!= Literal(Date.valueOf("2019-01-01"))) :: Nil,
     "datecol != 2019-01-01")
 
+  filterTest("not-in int filter",

Review comment:
       Shall we add a test case for `NULL` as while, e.g. NOT IN (1, 2, ..., NULL)? Given we have bug before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org