You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Mark Reynolds (JIRA)" <ta...@jakarta.apache.org> on 2006/03/25 01:10:22 UTC
[jira] Created: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
SpecificationResolverDelegate not consulted if component class found first
--------------------------------------------------------------------------
Key: TAPESTRY-894
URL: http://issues.apache.org/jira/browse/TAPESTRY-894
Project: Tapestry
Type: Bug
Components: Framework
Versions: 4.0
Reporter: Mark Reynolds
I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Commented: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Filip S. Adamsen (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=comments#action_12373579 ]
Filip S. Adamsen commented on TAPESTRY-894:
-------------------------------------------
I'd say this behaviour is counter-intuitive.
The .jwc file might as well be where the class is - why would you assume it to be in WEB-INF?
Perhaps there should be a component-spec-path configuration option? Or the SpecificationResolverDelegate could be consulted before assuming where the spec file is.
I'll look into this later and see if I can fix this.
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Reporter: Mark Reynolds
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Assigned: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=all ]
Jesse Kuhnert reassigned TAPESTRY-894:
--------------------------------------
Assignee: Jesse Kuhnert
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
> Assigned To: Jesse Kuhnert
> Attachments: ComponentSpecificationResolverImpl.java.patch
>
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=all ]
Jesse Kuhnert updated TAPESTRY-894:
-----------------------------------
Fix Version/s: 4.1.1
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
> Attachments: ComponentSpecificationResolverImpl.java.patch
>
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Martin Strand (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=all ]
Martin Strand updated TAPESTRY-894:
-----------------------------------
Attachment: ComponentSpecificationResolverImpl.java.patch
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
> Attachments: ComponentSpecificationResolverImpl.java.patch
>
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=all ]
Jesse Kuhnert resolved TAPESTRY-894.
------------------------------------
Resolution: Fixed
Applied changes. As far as I can tell if there are any performance concerns with this new order of calls they will only affect people with caching disabled, so production will remain pristine and as fast as it currently is.
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
> Attachments: ComponentSpecificationResolverImpl.java.patch
>
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Martin Strand (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=comments#action_12440708 ]
Martin Strand commented on TAPESTRY-894:
----------------------------------------
Any progress on this? It looks like a quick fix - just switch the search order in searchForComponent()...
Or, make searchForComponent protected so we can subclass ComponentSpecificationResolverImpl easily and override this behaviour.
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=comments#action_12454195 ]
Andreas Andreou commented on TAPESTRY-894:
------------------------------------------
I'd go with keeping the current behavior as is
and making searchForComponent, searchForComponentClass protected and adding
a protected getter for _classFinder (in ComponentSpecificationResolverImpl)
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0
> Reporter: Mark Reynolds
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
> Attachments: ComponentSpecificationResolverImpl.java.patch
>
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-894) SpecificationResolverDelegate not
consulted if component class found first
Posted by "Filip S. Adamsen (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-894?page=comments#action_12373657 ]
Filip S. Adamsen commented on TAPESTRY-894:
-------------------------------------------
Okay, so I changed ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle) to consult the delegate before searching for a class - and everything seems to work...
> SpecificationResolverDelegate not consulted if component class found first
> --------------------------------------------------------------------------
>
> Key: TAPESTRY-894
> URL: http://issues.apache.org/jira/browse/TAPESTRY-894
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Reporter: Mark Reynolds
>
> I am attempting to put my components under WEB-INF/component. I used the example from the wiki: http://wiki.apache.org/jakarta-tapestry/PagesAndComponentsInWEB-INF.
> My component's .jwc file is not found. Tracing through the code I see that in ComponentSpecificationResolverImpl.searchForComponent(IRequestCycle), if the .jwc file is not found in the usual locations, a search is done for the class. If the class is found, it is assumed the .jwc must be in WEB-INF and the configured SpecificationResolverDelegate is never consulted.
> This does not seem correct. Shouldn't all efforts to locate the .jwc be exhausted before searching for the class?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org