You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/20 14:54:07 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13181: Optimize shadow routing engine and shadow table rule

codecov-commenter commented on pull request #13181:
URL: https://github.com/apache/shardingsphere/pull/13181#issuecomment-947748252


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13181](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23e4647) into [master](https://codecov.io/gh/apache/shardingsphere/commit/be499b1367f70ba0e38260e626a600b9f5dff116?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be499b1) will **decrease** coverage by `0.35%`.
   > The diff coverage is `60.91%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13181/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #13181      +/-   ##
   ============================================
   - Coverage     63.63%   63.27%   -0.36%     
   + Complexity     1394     1388       -6     
   ============================================
     Files          2534     2542       +8     
     Lines         37925    37992      +67     
     Branches       6523     6527       +4     
   ============================================
   - Hits          24132    24040      -92     
   - Misses        11864    12059     +195     
   + Partials       1929     1893      -36     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ner/algorithm/ColumnShadowAlgorithmDeterminer.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RldGVybWluZXIvYWxnb3JpdGhtL0NvbHVtblNoYWRvd0FsZ29yaXRobURldGVybWluZXIuamF2YQ==) | `58.82% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowNonDMLStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2ltcGwvU2hhZG93Tm9uRE1MU3RhdGVtZW50Um91dGluZ0VuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ine/dml/AbstractShadowDMLStatementRouteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RtbC9BYnN0cmFjdFNoYWRvd0RNTFN0YXRlbWVudFJvdXRlRW5naW5lLmphdmE=) | `62.74% <47.36%> (+9.04%)` | :arrow_up: |
   | [.../apache/shardingsphere/shadow/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9TaGFkb3dSdWxlLmphdmE=) | `63.23% <47.82%> (-2.81%)` | :arrow_down: |
   | [...he/shardingsphere/shadow/rule/ShadowTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9TaGFkb3dUYWJsZVJ1bGUuamF2YQ==) | `94.44% <94.44%> (ø)` | |
   | [...ere/shadow/condition/ShadowDetermineCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvY29uZGl0aW9uL1NoYWRvd0RldGVybWluZUNvbmRpdGlvbi5qYXZh) | `83.33% <100.00%> (+15.15%)` | :arrow_up: |
   | [...ute/engine/determiner/ShadowDeterminerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RldGVybWluZXIvU2hhZG93RGV0ZXJtaW5lckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
   | [...miner/algorithm/NoteShadowAlgorithmDeterminer.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RldGVybWluZXIvYWxnb3JpdGhtL05vdGVTaGFkb3dBbGdvcml0aG1EZXRlcm1pbmVyLmphdmE=) | `63.63% <100.00%> (+3.63%)` | :arrow_up: |
   | [...engine/dml/ShadowDeleteStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RtbC9TaGFkb3dEZWxldGVTdGF0ZW1lbnRSb3V0aW5nRW5naW5lLmphdmE=) | `83.33% <100.00%> (ø)` | |
   | [...engine/dml/ShadowInsertStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RtbC9TaGFkb3dJbnNlcnRTdGF0ZW1lbnRSb3V0aW5nRW5naW5lLmphdmE=) | `80.76% <100.00%> (ø)` | |
   | ... and [69 more](https://codecov.io/gh/apache/shardingsphere/pull/13181/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [be499b1...23e4647](https://codecov.io/gh/apache/shardingsphere/pull/13181?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org