You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Bill Bell (JIRA)" <ji...@apache.org> on 2013/08/18 02:23:48 UTC

[jira] [Commented] (LUCENE-4698) Overhaul ShapeFieldCache because its a memory pig

    [ https://issues.apache.org/jira/browse/LUCENE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743072#comment-13743072 ] 

Bill Bell commented on LUCENE-4698:
-----------------------------------

This JIRA ticket is extremely important when using this ShapeFieldCache... David is there a way to :

1. Use FieldCache when the field is defined as non multivalue?
2. Add option to turn it off?

                
> Overhaul ShapeFieldCache because its a memory pig
> -------------------------------------------------
>
>                 Key: LUCENE-4698
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4698
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>         Attachments: solr_spatial_leak1.png
>
>
> The org.apache.lucene.spatial.util.ShapeFieldCache* classes together implement a spatial field cache for points, similar to FieldCache for other fields.  It supports a variable number of points per document, and it's currently only used by the SpatialPrefixTree strategy because that's the only strategy that supports a variable number of points per document.  The other spatial strategies use the FieldCache.  The ShapeFieldCache has problems:
> * It's a memory pig. Each point is stored as a Point object, instead of an array of x & y coordinates. Furthermore, each Point is in an ArrayList that exists for each Document. It's not done any differently when your spatial data isn't multi-valued.
> * The cache is not per-segment, it's per-IndexReader, thereby making it un-friendly to NRT search.
> * The cache entries don't self-expire optimally to free up memory. The cache is simply stored in a WeakHashMap<IndexReader,ShapeFieldCache>. The big cache entries are only freed when the WeakHashMap is used and the JVM realizes the IndexSearcher instance has been GC'ed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org