You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/12/13 01:09:16 UTC
Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/
-----------------------------------------------------------
Review request for hive and Jitendra Pandey.
Bugs: HIVE-6010
https://issues.apache.org/jira/browse/HIVE-6010
Repository: hive-git
Description
-------
See jira.
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
itests/qtest/pom.xml 8c249a0
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 4b6dc6a
ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
Diff: https://reviews.apache.org/r/16229/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review30486
-----------------------------------------------------------
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58320>
that is because the new test has no result directory, it compares outputs of multiple queries
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58321>
yeah, it ends up being written to build output. Do you think it should be written elsewhere?
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv
<https://reviews.apache.org/r/16229/#comment58355>
this will muddy the naming convention for versions and potentially cause ambiguity; discussed the details in person
- Sergey Shelukhin
On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 7:15 p.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Bugs: HIVE-6010
> https://issues.apache.org/jira/browse/HIVE-6010
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira.
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
> itests/qtest/pom.xml 8c249a0
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
> ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
> ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Dec. 16, 2013, 9:19 p.m., Jitendra Pandey wrote:
> > ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java, line 453
> > <https://reviews.apache.org/r/16229/diff/2/?file=397661#file397661line453>
> >
> > Is it ok to write to stdout?
yes, it ends up in build output
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review30464
-----------------------------------------------------------
On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 7:15 p.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Bugs: HIVE-6010
> https://issues.apache.org/jira/browse/HIVE-6010
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira.
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
> itests/qtest/pom.xml 8c249a0
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
> ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
> ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Jitendra Pandey <ji...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review30464
-----------------------------------------------------------
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58282>
We should throw an exception if it is null. What is the reason for the change in behavior?
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58283>
Is it ok to write to stdout?
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv
<https://reviews.apache.org/r/16229/#comment58288>
The name of the file could be suffixed to indicate vectorization disabled or enabled.
- Jitendra Pandey
On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 7:15 p.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Bugs: HIVE-6010
> https://issues.apache.org/jira/browse/HIVE-6010
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira.
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
> itests/qtest/pom.xml 8c249a0
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
> ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
> ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Jitendra Pandey <ji...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review30506
-----------------------------------------------------------
Ship it!
Ship It!
- Jitendra Pandey
On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 7:15 p.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Bugs: HIVE-6010
> https://issues.apache.org/jira/browse/HIVE-6010
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira.
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
> itests/qtest/pom.xml 8c249a0
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
> ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
> ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Jitendra Pandey <ji...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review31098
-----------------------------------------------------------
Ship it!
Ship It!
- Jitendra Pandey
On Dec. 17, 2013, 10:40 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 10:40 p.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Bugs: HIVE-6010
> https://issues.apache.org/jira/browse/HIVE-6010
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira.
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 79840c9
> itests/qtest/pom.xml 971c5d3
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 275e3d7
> ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
> ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
> ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/
-----------------------------------------------------------
(Updated Dec. 17, 2013, 10:40 p.m.)
Review request for hive and Jitendra Pandey.
Bugs: HIVE-6010
https://issues.apache.org/jira/browse/HIVE-6010
Repository: hive-git
Description
-------
See jira.
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 79840c9
itests/qtest/pom.xml 971c5d3
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 275e3d7
ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
Diff: https://reviews.apache.org/r/16229/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 7:15 p.m.)
Review request for hive and Jitendra Pandey.
Bugs: HIVE-6010
https://issues.apache.org/jira/browse/HIVE-6010
Repository: hive-git
Description
-------
See jira.
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
itests/qtest/pom.xml 8c249a0
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
Diff: https://reviews.apache.org/r/16229/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16229: HIVE-6010 create a test that would ensure
vectorization produces same results as non-vectorized execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 12:09 a.m.)
Review request for hive and Jitendra Pandey.
Bugs: HIVE-6010
https://issues.apache.org/jira/browse/HIVE-6010
Repository: hive-git
Description
-------
See jira.
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa
itests/qtest/pom.xml 8c249a0
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 4b6dc6a
ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION
ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION
ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION
Diff: https://reviews.apache.org/r/16229/diff/
Testing
-------
Thanks,
Sergey Shelukhin