[GitHub] [kafka] cmccabe commented on pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-789256987


   Thanks for the reviews! I reworked the authentication, validation, and de-duplication code a lot.  The new logic should take into account the issues pointed out here. I resolved a few comment threads since they refer to code that was refactored-- please take another look if you get a chance.
   
   To clarify a bit, `RemoveTopicRecord` should imply some other effects:
   * All topic configs for the affected topic should be deleted
   * We should delete all the partitions of the deleted topic
   * We should remove the topic from `brokersToIsrs`
   
   The fact that it wasn't doing these things was a bug... it's fixed now.  This should also allow the ducktape test to work (cc @rondagostino )
   
   We also have a JIRA to follow up on the broker side: https://issues.apache.org/jira/browse/KAFKA-12403


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org