You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/26 17:11:08 UTC

Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44075/
-----------------------------------------------------------

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
    https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
-------

Isolated shell argouments in a namespace.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp e0039fdab20ba547dc2bb78c544549c30c535294 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 

Diff: https://reviews.apache.org/r/44075/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

Posted by Yi Sun <yi...@hotmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44075/#review123003
-----------------------------------------------------------


Ship it!




Ship It!

- Yi Sun


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44075/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
>     https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Isolated shell argouments in a namespace.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp e0039fdab20ba547dc2bb78c544549c30c535294 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 
> 
> Diff: https://reviews.apache.org/r/44075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

Posted by Joris Van Remoortere <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44075/#review123092
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (lines 41 - 42)
<https://reviews.apache.org/r/44075/#comment185229>

    new line between last statement and closing namespace.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (line 143)
<https://reviews.apache.org/r/44075/#comment185230>

    2 lines between functions in a namespace.


- Joris Van Remoortere


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44075/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
>     https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Isolated shell argouments in a namespace.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp e0039fdab20ba547dc2bb78c544549c30c535294 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 
> 
> Diff: https://reviews.apache.org/r/44075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

Posted by Daniel Pravat <dp...@outlook.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44075/#review121119
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Pravat


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44075/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
>     https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Isolated shell argouments in a namespace.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp e0039fdab20ba547dc2bb78c544549c30c535294 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 
> 
> Diff: https://reviews.apache.org/r/44075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>