You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/01 18:02:22 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5974: [Arith] Constant cancellation added for subtraction

ANSHUMAN87 commented on pull request #5974:
URL: https://github.com/apache/incubator-tvm/pull/5974#issuecomment-652566834


   @tqchen : Thanks for your clear feedback! I did also have similar concerns here. These are some trivial issues I observed during my analysis. Now I understand canonicalization will resolve these.
   
   But keeping that in mind, I found some redundant rules still exists in rewrite simplify. 
   So as you see, the clear distinction is missing.
   So if it is possible, would you please help me understand what kind of rules should be part of rewrite simplify and which should be handled in canonical simplify. 
   This will help me put my future PR in right direction. TIA! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org