You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/18 11:47:27 UTC

[GitHub] [kafka] showuon edited a comment on pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

showuon edited a comment on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694776599


   > However I wonder if it would make sense to extract the part which waits until we go back to the initial count out of `verifyConnectionRate` into a dedicated helper method and to call it explicitly in the test. In the multi-threaded case, it does not make sense to block the two threads to wait on that condition. We could wait after they have finished their respective verification. That could improve the readability of the test in my opinion. What do you think? Would this work?
   
   @dajac  , thanks for your comments. That makes sense to me. I've updated in this commit: https://github.com/apache/kafka/pull/9301/commits/0b7a0b3e3d4df26812fa554e8ec7344a72453505. Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org