You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airavata.apache.org by GitBox <gi...@apache.org> on 2021/05/01 02:06:34 UTC
[GitHub] [airavata-django-portal] docquantum opened a new pull request #60: [Vue Input Editor] Async validators
docquantum opened a new pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60
This is the work done with @machristie for rna-nanostructures which enables async validators on the vue front end.
Commits were cherry-picked from [our own repository](https://github.com/cseseniordesign/rna-nanostructures) to only contain changes made to make validation async.
This requires [vue-async-computed](https://github.com/foxbenjaminfox/vue-async-computed) which is MIT licensed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] machristie merged pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
machristie merged pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] docquantum commented on a change in pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
docquantum commented on a change in pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60#discussion_r624432285
##########
File path: django_airavata/static/common/js/entry.js
##########
@@ -1,6 +1,7 @@
import Vue from "vue";
import BootstrapVue from "bootstrap-vue";
import GlobalErrorHandler from "./errors/GlobalErrorHandler";
+import AsyncComputed from 'vue-async-computed';
Review comment:
Needs to be double quotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] machristie commented on pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
machristie commented on pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60#issuecomment-841220759
Daniel this looks great! That's for putting this into a PR. I'm going to do some local testing and then if all goes well I'll merge it.
I did have one question, can you point me to the async file validator you all created? I think that would be a good contribution too if it can be generalized. I'm assuming it's in your airavata-django-portal fork.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] machristie commented on pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
machristie commented on pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60#issuecomment-841448947
Perfect, thanks @docquantum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] docquantum commented on a change in pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
docquantum commented on a change in pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60#discussion_r624432285
##########
File path: django_airavata/static/common/js/entry.js
##########
@@ -1,6 +1,7 @@
import Vue from "vue";
import BootstrapVue from "bootstrap-vue";
import GlobalErrorHandler from "./errors/GlobalErrorHandler";
+import AsyncComputed from 'vue-async-computed';
Review comment:
Needs to be double quotes`
```suggestion
import AsyncComputed from "vue-async-computed";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-django-portal] docquantum commented on pull request #60: [Vue Input Editor] Async validators
Posted by GitBox <gi...@apache.org>.
docquantum commented on pull request #60:
URL: https://github.com/apache/airavata-django-portal/pull/60#issuecomment-841321205
Here's an example:
[django_airavata/apps/api/static/django_airavata_api/js/models/validators/PDBFileValidator.js](https://github.com/unlhcc/rna-nanostructures/blob/master/django_airavata/apps/api/static/django_airavata_api/js/models/validators/PDBFileValidator.js)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org