[GitHub] flink pull request #5765: [FLINK-9063] Fix SpillableSubpartitionTest testSpi...

[pnowojski <gi...@git.apache.org>]

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/5765

    [FLINK-9063] Fix SpillableSubpartitionTest testSpillFinishedBufferConsumers

    testSpillFinishedBufferConsumers was incorrectly manually closing the BufferConsumer
    after passing it's ownership to the ResultSubpartition. This was leading to a race
    conditions with AsynchronousBufferFileWriter.
    
    This is a change in tests that improves stability.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink f9063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5765
    
----

----


---

[GitHub] flink issue #5765: [FLINK-9063] Fix SpillableSubpartitionTest testSpillFinis...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5765
  
    Thanks for the fix @pnowojski and the review @NicoK. Merging this PR.


---

[GitHub] flink pull request #5765: [FLINK-9063] Fix SpillableSubpartitionTest testSpi...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5765


---