You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/03/31 00:19:01 UTC
[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15608
Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
......................................................................
[client] Add a note that only FAST_HASH is supported in Bloom filter predicate
Add explicit note that only FAST_HASH is supported in the Bloom filter
predicate in client API.
There is already validation in BlockBloomFilter for hash algorithm.
Test:
- Verified the generated HTML output.
Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
---
M src/kudu/client/scan_predicate.h
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/15608/1
--
To view, visit http://gerrit.cloudera.org:8080/15608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
Gerrit-Change-Number: 15608
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15608 )
Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
Gerrit-Change-Number: 15608
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 05:26:45 +0000
Gerrit-HasComments: No
[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15608 )
Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
......................................................................
[client] Add a note that only FAST_HASH is supported in Bloom filter predicate
Add explicit note that only FAST_HASH is supported in the Bloom filter
predicate in client API.
There is already validation in BlockBloomFilter for hash algorithm.
Test:
- Verified the generated HTML output.
Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
Reviewed-on: http://gerrit.cloudera.org:8080/15608
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/scan_predicate.h
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
Gerrit-Change-Number: 15608
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)