You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by js...@apache.org on 2017/09/28 06:43:41 UTC
spark git commit: [SPARK-22135][MESOS] metrics in spark-dispatcher
not being registered properly
Repository: spark
Updated Branches:
refs/heads/master 3b117d631 -> f20be4d70
[SPARK-22135][MESOS] metrics in spark-dispatcher not being registered properly
## What changes were proposed in this pull request?
Fix a trivial bug with how metrics are registered in the mesos dispatcher. Bug resulted in creating a new registry each time the metricRegistry() method was called.
## How was this patch tested?
Verified manually on local mesos setup
Author: Paul Mackles <pm...@adobe.com>
Closes #19358 from pmackles/SPARK-22135.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f20be4d7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f20be4d7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f20be4d7
Branch: refs/heads/master
Commit: f20be4d70bf321f377020d1bde761a43e5c72f0a
Parents: 3b117d6
Author: Paul Mackles <pm...@adobe.com>
Authored: Thu Sep 28 14:43:31 2017 +0800
Committer: jerryshao <ss...@hortonworks.com>
Committed: Thu Sep 28 14:43:31 2017 +0800
----------------------------------------------------------------------
.../scheduler/cluster/mesos/MesosClusterSchedulerSource.scala | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f20be4d7/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSource.scala
----------------------------------------------------------------------
diff --git a/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSource.scala b/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSource.scala
index 1fe9497..76aded4 100644
--- a/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSource.scala
+++ b/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSource.scala
@@ -23,8 +23,9 @@ import org.apache.spark.metrics.source.Source
private[mesos] class MesosClusterSchedulerSource(scheduler: MesosClusterScheduler)
extends Source {
- override def sourceName: String = "mesos_cluster"
- override def metricRegistry: MetricRegistry = new MetricRegistry()
+
+ override val sourceName: String = "mesos_cluster"
+ override val metricRegistry: MetricRegistry = new MetricRegistry()
metricRegistry.register(MetricRegistry.name("waitingDrivers"), new Gauge[Int] {
override def getValue: Int = scheduler.getQueuedDriversSize
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org