You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:03:45 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10541: ARROW-13092: [C++] Return an error in CreateDir if target is a file

pitrou commented on a change in pull request #10541:
URL: https://github.com/apache/arrow/pull/10541#discussion_r653788861



##########
File path: cpp/src/arrow/filesystem/test_util.cc
##########
@@ -206,7 +206,10 @@ void GenericFileSystemTest::TestCreateDir(FileSystem* fs) {
   // Cannot create a directory as child of a file
   CreateFile(fs, "AB/def", "");
   ASSERT_RAISES(IOError, fs->CreateDir("AB/def/EF/GH", true /* recursive */));
-  ASSERT_RAISES(IOError, fs->CreateDir("AB/def/EF", false /* recursive */));
+  ASSERT_RAISES(IOError, fs->CreateDir("AB/def/EF/GH", true /* recursive */));

Review comment:
       Definitely not, will fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org