You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/23 14:20:36 UTC

[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #2866: [Imporve][Connector-V2]Parameter verification for connector V2 kafka sink

TaoZex commented on code in PR #2866:
URL: https://github.com/apache/incubator-seatunnel/pull/2866#discussion_r978727459


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java:
##########
@@ -136,7 +136,7 @@ private Properties getKafkaProperties(Config pluginConfig) {
 
     // todo: parse the target field from config
     private SeaTunnelRowSerializer<byte[], byte[]> getSerializer(Config pluginConfig, SeaTunnelRowType seaTunnelRowType) {
-        return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topics"), seaTunnelRowType);
+        return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topic"), seaTunnelRowType);

Review Comment:
   Thans,i will modify it.
   https://github.com/apache/incubator-seatunnel/pull/2863 This pr does not conflict with the current pr, because this is the doc of the connector V1 version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org