[GitHub] cewood commented on a change in pull request #6496: [FLINK-10063][tests] Use runit to supervise mesos processes.

[GitBox <gi...@apache.org>]

cewood commented on a change in pull request #6496: [FLINK-10063][tests] Use runit to supervise mesos processes.
URL: https://github.com/apache/flink/pull/6496#discussion_r207790888
 
 

 ##########
 File path: flink-jepsen/docker/Dockerfile-db
 ##########
 @@ -35,5 +35,12 @@ RUN mkdir -p /root/.ssh/ && \
     chmod 600 /root/.ssh/authorized_keys && \
     cat /root/id_rsa.pub >> /root/.ssh/authorized_keys
 
+COPY sshd-run /etc/sv/service/sshd/run
+RUN chmod +x /etc/sv/service/sshd/run && \
+    ln -sf /etc/sv/service/sshd /etc/service
+
 EXPOSE 22
-CMD exec /usr/sbin/sshd -D
+
+# Start runit process supervisor which will bring up sshd.
+# In our tests we can use runit to supervise more processes, e.g., Mesos.
+CMD runsvdir -P /etc/service /dev/null > /dev/null
 
 Review comment:
   Is the extra `> /dev/null` actually required? I would have expected that the log argument to `/dev/null` alone would have sufficed, since it also redirects standard error according to the docs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services