You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/10 04:25:20 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #41913: [SPARK-44290][CONNECT][FOLLOW-UP] Skip flaky tests, and fix a typo in session UUID together
HyukjinKwon opened a new pull request, #41913:
URL: https://github.com/apache/spark/pull/41913
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/41495 that skips a couple of flaky tests. In addition, this PR fixes a typo together.
### Why are the changes needed?
To keep the tests green. In order to reenable the tests, it needs other fixes together that might refactor the whole test cases which takes a while. I will followup and fix them in SPARK-44348
### Does this PR introduce _any_ user-facing change?
No, the feature is not released to end users yet.
### How was this patch tested?
Unittests skipped for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #41913: [SPARK-44290][CONNECT][FOLLOW-UP] Skip flaky tests, and fix a typo in session UUID together
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #41913:
URL: https://github.com/apache/spark/pull/41913#discussion_r1257736725
##########
python/pyspark/sql/tests/connect/client/test_artifact.py:
##########
@@ -245,6 +245,7 @@ def func(x):
spark_session.addArtifacts(pyfile_path, pyfile=True)
self.assertEqual(spark_session.range(1).select(func("id")).first()[0], 10)
+ @unittest.skip("SPARK-44348: Reeanble Session-based artifact test cases")
Review Comment:
```suggestion
@unittest.skip("SPARK-44348: Reenable Session-based artifact test cases")
```
##########
python/pyspark/sql/tests/connect/client/test_artifact.py:
##########
@@ -272,6 +273,7 @@ def func(x):
spark_session.addArtifacts(f"{package_path}.zip", pyfile=True)
self.assertEqual(spark_session.range(1).select(func("id")).first()[0], 5)
+ @unittest.skip("SPARK-44348: Reeanble Session-based artifact test cases")
Review Comment:
```suggestion
@unittest.skip("SPARK-44348: Reenable Session-based artifact test cases")
```
##########
python/pyspark/sql/tests/connect/client/test_artifact.py:
##########
@@ -328,6 +331,7 @@ def func(x):
spark_session.addArtifacts(file_path, file=True)
self.assertEqual(spark_session.range(1).select(func("id")).first()[0], "Hello world!!")
+ @unittest.skip("SPARK-44348: Reeanble Session-based artifact test cases")
Review Comment:
```suggestion
@unittest.skip("SPARK-44348: Reenable Session-based artifact test cases")
```
##########
python/pyspark/sql/tests/connect/client/test_artifact.py:
##########
@@ -303,6 +305,7 @@ def func(x):
spark_session.addArtifacts(f"{archive_path}.zip#my_files", archive=True)
self.assertEqual(spark_session.range(1).select(func("id")).first()[0], "hello world!")
+ @unittest.skip("SPARK-44348: Reeanble Session-based artifact test cases")
Review Comment:
```suggestion
@unittest.skip("SPARK-44348: Reenable Session-based artifact test cases")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41913: [SPARK-44290][CONNECT][FOLLOW-UP] Skip flaky tests, and fix a typo in session UUID together
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41913: [SPARK-44290][CONNECT][FOLLOW-UP] Skip flaky tests, and fix a typo in session UUID together
URL: https://github.com/apache/spark/pull/41913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41913: [SPARK-44290][CONNECT][FOLLOW-UP] Skip flaky tests, and fix a typo in session UUID together
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41913:
URL: https://github.com/apache/spark/pull/41913#issuecomment-1628292757
Thank you @yaooqinn . I am merging it in - the tests passed, and the last changes are just typos in the message.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org